Refactor strip_web_protocol() #126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows for more prefixes to be added in the future if needed without repeating code multiple times.
tagstudio/src/core/utils/web.py
Outdated
| prefixes = ['https://','http://','www.','www2.'] | ||
| for prefix in prefixes: | ||
| if string.startswith(prefix): | ||
| string = string.replace(prefix, '') |
There was a problem hiding this comment.
consider following example:
>>> 'www.foowww.com'.replace('www.', '')
'foocom'
There was a problem hiding this comment.
This should handle it. Basically replacing only the first occurance of the prefix
>>> 'www.foowww.com'.replace('www.', '', 1)
'foowww.com'
There was a problem hiding this comment.
...why not keep it simple?
- if string.startswith(prefix):
- string = string.replace(prefix, '')
+ string = string.removeprefix(prefix)There was a problem hiding this comment.
I meant to leave it as string.removeprefix() but didn't change it back for my commit. Also @yedpodtrzitko your right we should keep it simple. I've went ahead and changed this in my latest commit.
Loran425
added
the
Type: Refactor
|
Functionally identical, looks good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows for more prefixes to be added in the future if needed without repeating code multiple times.