Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separately pin QT nixpkg version #244

Merged
merged 3 commits into from
Jun 10, 2024

Conversation

seakrueger
Copy link
Contributor

By pinning QT separately, the rest of dependent nixpkgs can be updated without being affected by the current QT version in nixpkgs unstable. The nixpkg revision is also bumped, fixing an issue where vim would immediately segfault on launch in the nix dev shell. This is for QT version 6.6.3, for when #223 is merged, the nixpkg commit tied to QT will need to be bumped to commit 47da0aee5616a063015f10ea593688646f2377e4.

Also adds missing dependecies from the new video player.

@xarvex
Copy link
Member

xarvex commented Jun 6, 2024

Meant to respond to this earlier but I have been busy on vacation. I'm currently almost up to a stable NixOS setup so I can actually test this, on a glance though this seems great!
Will follow up as soon as I have more.

@CyanVoxel CyanVoxel modified the milestones: Alpha 9.3, NixOS Support Jun 7, 2024
Currently, this succesfully launches the program. Pinning qt seperatly
allows the rest of unstable nixpkgs to be updated even after the qt
package version has been bumped. This fixes vim failing to launch in the
nix shell because of a bad gcc version. Bumping the package version to
qt6.7.1 also will require bumping PySide to 6.7.1, otherwise it will
fail to find qt. Qt 6.7.1 nixpkg commit is 47da0aee5616a063015f10ea593688646f2377e4
QtCreator was still against nixpkgs not the specific qt variant.
@xarvex
Copy link
Member

xarvex commented Jun 10, 2024

Confirmed working on NixOS, able to manipulate and create libraries. This is currently hardcoded to x86_64 on Linux, but so was the original flake, and is out of the scope of just making this work. I will make my own PR to address that (and I also don't want to mess up #229).
On the topic of #229, I see it is based on this PR. Is it just in a draft until this gets used?

CC @CyanVoxel - ready to be merged

@xarvex xarvex added Priority: Medium An issue that shouldn't be be saved for last Status: Mergeable The code is ready to be merged labels Jun 10, 2024
@CyanVoxel CyanVoxel merged commit 7054ffd into TagStudioDev:main Jun 10, 2024
3 checks passed
@xarvex xarvex removed the Priority: Medium An issue that shouldn't be be saved for last label Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Mergeable The code is ready to be merged Type: Installation Installing, building, and/or launching the program
Projects
Status: Done
3 participants