Detach Library loading from Render thread #297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CyanVoxel
added
Type: Enhancement
|
Don't worry about the Pyside app test failing for now (its a bug that is fixed now). But if you want to you can fix it by pulling the changes from the main branch and merging it into yours. |
To get the return code from lib.open_library, CustomRunnable needs the ability to return the int value. Since CustomRunnable is designed to be generic, the signal returns of a value of any `object` type.
In scenarios where the library takes a long amount of time, the application would become locked up and unresponsive, as library loading was blocking. By detaching library loading to its own thread, the program remains responsive even while the library is loading.
Prevents the same hang-up from loading an existing library for when a new library is being created or additional entries are being added. As `add_new_files_runnable` is no longer blocking, an additional signal was needed to be added for the program to know when it was safe to display the library.
seakrueger
force-pushed
the
detach-library-loading
branch
from
f127387
to
0459d85
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In scenarios where the library takes a long amount of time to load, the application would become locked up and unresponsive, as library loading was blocking. By detaching library loading to its own thread, the program remains responsive even while the library is loading.
Eventually, a ProgressWidget should probably be added, but that would require a signifigant change to the logic of lib.open_library.