-
Notifications
You must be signed in to change notification settings - Fork 249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mutli-Select Tagging #34
Conversation
2024-04-24.22-03-40.mp4works with latest commit(e69e499) using python 3.12.3 |
So I rewrote how Multi-Select actually gets the field id, and now it works perfectly (Tested the bugs from earlier commits, and should not corrupt your library now, hopefully.) |
Glad to see it working a lot better now! Tags seem to be applied to the correct fields now and no more library corruption ;) Unfortunately I found a bug involving badges: By selecting one or more entries, then clicking the favorite or archived badge on an unselected entry, it instead tries applying the tag badge that was clicked to the selected entrie(s) instead of the entry that was clicked. Less immediately important, but I'm also noticing the thumbnails re-rendering whenever a badge updates, instead of just calling the Feel free to keep the PR open or convert it to a draft - closing and reopening it messed with my git and I had to re-clone the repo in order to test the branch out again :) |
Really excellent work!! This is an incredible feature to finally have implemented! I'm so sorry for the mess of my code that needed sorting out in order for this to work... I really appreciate you doing this though, and continuing to keep coming back with new fixes! In the meantime, stress testing this PR has led me to discover a couple preexisting bugs regarding the multi-selection metadata system, one being the mentioned "field deletion not updating the badge" (#56), and a much more critical one (#55) that can cause library corruption. Anyway, I'm mentioning these because I'm going to investigate the cause of those before pulling in this branch, since this makes significant changes to the same system. I plan on pulling this one first before any potential fix to the outside bugs, however I just wanted to update you on why I haven't pulled it in the meantime. Thanks again for all your hard work on this! |
Adds some basic multi-select tagging for Tag Studio
https://youtu.be/xGxPZ0_GBI0