Skip to content
This repository has been archived by the owner on Apr 6, 2021. It is now read-only.

Add support for <kbd> #189

Merged
merged 2 commits into from
Sep 3, 2016
Merged

Add support for <kbd> #189

merged 2 commits into from
Sep 3, 2016

Conversation

lodelestra
Copy link
Contributor

#129

By following the 'cite' example, this version is far better!

@willdurand
Copy link
Member

Great! The code looks good to me. What I am wondering is how it looks in the preview?

@lodelestra
Copy link
Contributor Author

The preview looks like this:
monod_kbd_preview

@lodelestra
Copy link
Contributor Author

Whitespaces aren't allowed in a key. You can't write 'cmd + p' in a single key.
Do you want to allow whitespaces?

@willdurand
Copy link
Member

Yep, I think spaces should be allowed. According to http://meta.stackoverflow.com/questions/270967/proper-use-of-the-kbd-tag, there is no reason not to allow them.

@lodelestra
Copy link
Contributor Author

lodelestra commented Sep 3, 2016

kbd recursive inclusion like [[ [[foo]] [[bar]] ]] isn't supported. This can be an issue too.

@willdurand
Copy link
Member

kbd recursive inclusion like [[ [[foo]] [[bar]] ]] isn't supported. This can be an issue too.

For this, I don't think it is a bad thing to be honest.

@willdurand willdurand merged commit 7c39b9f into TailorDev:master Sep 3, 2016
@willdurand
Copy link
Member

thank you for your work!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants