This repository has been archived by the owner on Apr 6, 2021. It is now read-only.
Improve Citation support #396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willdurand
reviewed
Feb 27, 2017
app/bibtex.js
Outdated
| @@ -15,9 +15,13 @@ function optional(string, fallback) { | |||
| return undefined !== str ? `(${str})` : ''; | |||
| } | |||
|
|
|||
| function validUrl(string) { | |||
| return (/^https?:\/\//.test(string) || /^ftp:\/\//.test(string)) | |||
There was a problem hiding this comment.
missing trailing semi-colon :)
|
Looks good to me, only a tiny mistake |
|
Ups, yeah, right. I normally do Python ;) fixed it |
jmaupetit
reviewed
Feb 28, 2017
app/bibtex.js
Outdated
| @@ -15,9 +15,13 @@ function optional(string, fallback) { | |||
| return undefined !== str ? `(${str})` : ''; | |||
| } | |||
|
|
|||
| function validUrl(string) { | |||
There was a problem hiding this comment.
What about naming this function isValidUrl?
There was a problem hiding this comment.
hm... yeah good point. I will change this.
|
Looks good to me too. Thanks @PaulDebus ! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey,
I wanted to contribute some small changes, that make my work easier.
I am using monod for a scientific work and I need to cite many online resources. So I introduced the
onlinecitation type.I also added some documentation for the supported citation types, because it took my a while to figure out which I could use.
Thanks for looking into it, tell me if there is something I need to change or clarify.
Kind Regards
Paul