TAKT-5626 Exports dhtmlx names for google CC #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What did you have to do to that JS blob? |
|
I was just writing that in the comments! I had to export all identifiers that are referenced in downstream code. That ended up not being many (dhx, dhx4, dhtmlxEvents) but i had to deconstruct that blob and put the exports in the correct places which was a little tricky. |
|
Can you document that somewhere, so that if we want to upgrade to a newer version of the upstream lib in the future we'll know how to duplicate your work? Perhaps in README.md. |
|
Documented in takt-core's readme. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.