fix: remove warn from console #2013
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romainseb
commented
Feb 28, 2019
| @@ -25,7 +25,7 @@ function ActionIconToggle(props) { | |||
| className={cn} | |||
| aria-label={label} | |||
| aria-pressed={active} | |||
| bsStyle="" | |||
| bsStyle="default" | |||
There was a problem hiding this comment.
You sure it didn't break the style ? I tested that too but, the colors change a bit (different grey or blue) :s
There was a problem hiding this comment.
i have use link bsStyle to have the same behaviour now :)
smouillour
approved these changes
May 6, 2019
jmfrancois
changed the title
sgangnant
approved these changes
May 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the problem this PR is trying to solve?
There is some warns
What is the chosen solution to this problem?
Wrong prop passed to button in ActionIconToggle
CSSTransition.childContextTypes has to be declared, even empty since React 16 ( wikiwi/react-css-transition#5 )
Skeleton props are not matched
Please check if the PR fulfills these requirements
[ ] This PR introduces a breaking change