Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cmf): Export registry for Apps using noRender option #3667

Closed
wants to merge 1 commit into from

Conversation

gjou-tlnd
Copy link
Contributor

@gjou-tlnd gjou-tlnd commented Feb 1, 2022

What is the problem this PR is trying to solve?

Registry provider needs a registry value since #3027
<RegistryProvider value={props.registry}>

What is the chosen solution to this problem?

export it when used with norender option

Please check if the PR fulfills these requirements

  • The PR have used yarn changeset to a request a release from the CI if wanted.
  • The PR commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features) And non reg done before need review
  • Docs have been added / updated (for bug fixes / features)
  • Related design / discussions / pages (not in jira), if any, are all linked or available in the PR

[ ] This PR introduces a breaking change

@gjou-tlnd gjou-tlnd temporarily deployed to pull_request_unsafe February 1, 2022 10:39 Inactive
@gjou-tlnd gjou-tlnd temporarily deployed to pull_request_unsafe February 1, 2022 10:39 Inactive
@gjou-tlnd gjou-tlnd temporarily deployed to pull_request_unsafe February 1, 2022 10:39 Inactive
@github-actions
Copy link
Contributor

github-actions bot commented Feb 1, 2022

3667

:octocat: Demo is available here

@github-actions
Copy link
Contributor

github-actions bot commented Feb 1, 2022

Size Change: +78 B (0%)

Total Size: 14.9 MB

ℹ️ View Unchanged
Filename Size Change
./packages/cmf-cqrs/dist/TalendReactCmfCqrs.js 35.6 kB 0 B
./packages/cmf-cqrs/dist/TalendReactCmfCqrs.js.dependencies.json 538 B 0 B
./packages/cmf-cqrs/dist/TalendReactCmfCqrs.min.js 6.81 kB 0 B
./packages/cmf-cqrs/dist/TalendReactCmfCqrs.min.js.dependencies.json 557 B 0 B
./packages/cmf-router/dist/TalendReactCmfRouter.js 52.6 kB 0 B
./packages/cmf-router/dist/TalendReactCmfRouter.js.dependencies.json 1.07 kB 0 B
./packages/cmf-router/dist/TalendReactCmfRouter.min.js 11.5 kB 0 B
./packages/cmf-router/dist/TalendReactCmfRouter.min.js.dependencies.json 1.11 kB 0 B
./packages/cmf/dist/TalendReactCmf.js 548 kB +66 B (0%)
./packages/cmf/dist/TalendReactCmf.js.dependencies.json 1.25 kB 0 B
./packages/cmf/dist/TalendReactCmf.min.js 112 kB +12 B (0%)
./packages/cmf/dist/TalendReactCmf.min.js.dependencies.json 1.29 kB 0 B
./packages/components/dist/TalendReactComponents.css 148 kB 0 B
./packages/components/dist/TalendReactComponents.js 3.19 MB 0 B
./packages/components/dist/TalendReactComponents.js.dependencies.json 2.86 kB 0 B
./packages/components/dist/TalendReactComponents.min.js 704 kB 0 B
./packages/components/dist/TalendReactComponents.min.js.dependencies.json 2.94 kB 0 B
./packages/containers/dist/TalendReactContainers.css 1.5 kB 0 B
./packages/containers/dist/TalendReactContainers.js 442 kB 0 B
./packages/containers/dist/TalendReactContainers.js.dependencies.json 1.41 kB 0 B
./packages/containers/dist/TalendReactContainers.min.js 95.2 kB 0 B
./packages/containers/dist/TalendReactContainers.min.js.dependencies.json 1.45 kB 0 B
./packages/datagrid/dist/TalendReactDatagrid.css 65.4 kB 0 B
./packages/datagrid/dist/TalendReactDatagrid.js 304 kB 0 B
./packages/datagrid/dist/TalendReactDatagrid.js.dependencies.json 1.23 kB 0 B
./packages/datagrid/dist/TalendReactDatagrid.min.js 61.5 kB 0 B
./packages/datagrid/dist/TalendReactDatagrid.min.js.dependencies.json 1.26 kB 0 B
./packages/dataviz/dist/TalendReactDataviz.css 4.6 kB 0 B
./packages/dataviz/dist/TalendReactDataviz.js 820 kB 0 B
./packages/dataviz/dist/TalendReactDataviz.js.dependencies.json 853 B 0 B
./packages/dataviz/dist/TalendReactDataviz.min.js 597 kB 0 B
./packages/dataviz/dist/TalendReactDataviz.min.js.dependencies.json 876 B 0 B
./packages/design-system/dist/TalendDesignSystem.css 1.11 MB 0 B
./packages/design-system/dist/TalendDesignSystem.js 989 kB 0 B
./packages/design-system/dist/TalendDesignSystem.js.dependencies.json 1.18 kB 0 B
./packages/design-system/dist/TalendDesignSystem.min.js 341 kB 0 B
./packages/design-system/dist/TalendDesignSystem.min.js.dependencies.json 1.21 kB 0 B
./packages/design-tokens/dist/TalendDesignTokens.css 32.3 kB 0 B
./packages/design-tokens/dist/TalendDesignTokens.js 30.9 kB 0 B
./packages/design-tokens/dist/TalendDesignTokens.js.dependencies.json 2 B 0 B
./packages/design-tokens/dist/TalendDesignTokens.min.js 25.8 kB 0 B
./packages/design-tokens/dist/TalendDesignTokens.min.js.dependencies.json 2 B 0 B
./packages/faceted-search/dist/TalendReactFacetedSearch.css 10.5 kB 0 B
./packages/faceted-search/dist/TalendReactFacetedSearch.js 367 kB 0 B
./packages/faceted-search/dist/TalendReactFacetedSearch.js.dependencies.json 1.1 kB 0 B
./packages/faceted-search/dist/TalendReactFacetedSearch.min.js 92.3 kB 0 B
./packages/faceted-search/dist/TalendReactFacetedSearch.min.js.dependencies.json 1.14 kB 0 B
./packages/flow-designer/dist/TalendReactFlowDesigner.min.js 89.9 kB 0 B
./packages/flow-designer/dist/TalendReactFlowDesigner.min.js.dependencies.json 854 B 0 B
./packages/forms/dist/TalendReactForms.css 17 kB 0 B
./packages/forms/dist/TalendReactForms.js 1.35 MB 0 B
./packages/forms/dist/TalendReactForms.js.dependencies.json 1.77 kB 0 B
./packages/forms/dist/TalendReactForms.min.js 419 kB 0 B
./packages/forms/dist/TalendReactForms.min.js.dependencies.json 1.82 kB 0 B
./packages/http/dist/TalendHttp.js 25.7 kB 0 B
./packages/http/dist/TalendHttp.js.dependencies.json 2 B 0 B
./packages/http/dist/TalendHttp.min.js 4.82 kB 0 B
./packages/http/dist/TalendHttp.min.js.dependencies.json 2 B 0 B
./packages/icons/dist/bundle.js 6.31 kB 0 B
./packages/icons/dist/info.js 10.7 kB 0 B
./packages/icons/dist/react.esm.js 529 kB 0 B
./packages/icons/dist/react.js 569 kB 0 B
./packages/icons/dist/talend-icons-webfont.css 16.6 kB 0 B
./packages/icons/dist/talendicons.css 334 B 0 B
./packages/icons/dist/TalendIcons.js 625 kB 0 B
./packages/icons/dist/TalendIcons.js.dependencies.json 128 B 0 B
./packages/icons/dist/TalendIcons.min.js 553 kB 0 B
./packages/icons/dist/TalendIcons.min.js.dependencies.json 131 B 0 B
./packages/jsfc/dist/index.js 95.3 kB 0 B
./packages/jsfc/dist/index.js.dependencies.json 2 B 0 B
./packages/router-bridge/dist/TalendRouterBridge.js 145 kB 0 B
./packages/router-bridge/dist/TalendRouterBridge.js.dependencies.json 981 B 0 B
./packages/router-bridge/dist/TalendRouterBridge.min.js 24.5 kB 0 B
./packages/router-bridge/dist/TalendRouterBridge.min.js.dependencies.json 1.01 kB 0 B
./packages/sagas/dist/TalendReactSagas.js 12.1 kB 0 B
./packages/sagas/dist/TalendReactSagas.js.dependencies.json 348 B 0 B
./packages/sagas/dist/TalendReactSagas.min.js 2.13 kB 0 B
./packages/sagas/dist/TalendReactSagas.min.js.dependencies.json 360 B 0 B
./packages/stepper/dist/TalendReactStepper.js 26.3 kB 0 B
./packages/stepper/dist/TalendReactStepper.js.dependencies.json 833 B 0 B
./packages/stepper/dist/TalendReactStepper.min.js 4.86 kB 0 B
./packages/stepper/dist/TalendReactStepper.min.js.dependencies.json 855 B 0 B
./packages/theme/dist/bootstrap.css 149 kB 0 B
./packages/theme/dist/bootstrap.js 4.33 kB 0 B
./packages/theme/dist/bootstrap.js.dependencies.json 3 B 0 B

compressed-size-action

@gjou-tlnd gjou-tlnd closed this Feb 1, 2022
@gjou-tlnd gjou-tlnd deleted the gjou/fix/cmf_export_registry branch February 1, 2022 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants