-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new PR demo on gh pages #4935
base: master
Are you sure you want to change the base?
new PR demo on gh pages #4935
Conversation
Size Change: +28 B (0%) Total Size: 13.2 MB ℹ️ View Unchanged
|
SURGE_LOGIN: ${{ secrets.SURGE_LOGIN }} | ||
SURGE_TOKEN: ${{ secrets.SURGE_TOKEN }} | ||
|
||
- name: Deploy to Netlify production |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we need to keep and fix netlify
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yep, but it is the file for PR, and from what I see we only want netlify for master, so it will be in the workflow for the master branch
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no, this workflow is also called on master branch
What is the problem this PR is trying to solve?
Current demo is deployed with Surge and Netlify.
What is the chosen solution to this problem?
Use Github Pages instead.
Please check if the PR fulfills these requirements
yarn changeset
to a request a release from the CI if wanted.[ ] This PR introduces a breaking change