Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(DGHT-180): fix InputDateTimeRangePicker gets wrong error message for multiple errors #5388

Merged
merged 1 commit into from
Aug 12, 2024
Merged

fix(DGHT-180): fix InputDateTimeRangePicker gets wrong error message for multiple errors #5388

merged 1 commit into from
Aug 12, 2024

Conversation

hbhong
Copy link
Collaborator

@hbhong hbhong commented Aug 12, 2024 •
edited
Loading

What is the problem this PR is trying to solve?
InputDateTimeRangePicker component gets wrong error message for multiple errors.
To reproduce:
1.Init component with start time and end time, there is no error message.
2. Remove the date from date field for the end time, it shows "Date is required", it is ok.
3. Remove the time from time field for the start time, it shows "Time is required", it is ok.
4. Refill the time field for the start time, it shows "Start date should comes before end date", it should show the remaining error "Date is required".

What is the chosen solution to this problem?

Please check if the PR fulfills these requirements

  • The PR have used yarn changeset to a request a release from the CI if wanted.
  • The PR commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features) And non reg done before need review
  • Docs have been added / updated (for bug fixes / features)
  • Related design / discussions / pages (not in jira), if any, are all linked or available in the PR

[ ] This PR introduces a breaking change

@hbhong hbhong temporarily deployed to pull_request_unsafe August 12, 2024 07:43 — with GitHub Actions Inactive
@hbhong hbhong temporarily deployed to pull_request_unsafe August 12, 2024 07:43 — with GitHub Actions Inactive
@hbhong hbhong temporarily deployed to pull_request_unsafe August 12, 2024 07:43 — with GitHub Actions Inactive
@github-actions GitHub Actions
Copy link
Contributor

5388

:octocat: Demo is available here

@github-actions GitHub Actions
Copy link
Contributor

Title Lines Statements Branches Functions
assets-api Coverage: 28%
 28.4% (25/88) 30.76% (16/52) 21.42% (3/14)
cmf Coverage: 89%
 89.18% (1237/1387) 80.88% (605/748) 89.28% (350/392)
cmf-cqrs Coverage: 87%
 87.43% (160/183) 70.23% (59/84) 84.21% (48/57)
cmf-router Coverage: 70%
 69.23% (135/195) 55.71% (78/140) 56.81% (25/44)
components Coverage: 90%
 90.8% (5528/6088) 81.84% (3206/3917) 88.14% (1390/1577)
containers Coverage: 84%
 83.71% (1388/1658) 74.81% (692/925) 75.17% (327/435)
dataviz Coverage: 85%
 85.44% (323/378) 66.66% (160/240) 75.79% (119/157)
design-system Coverage: 67%
 66.75% (996/1492) 50.85% (536/1054) 54.54% (216/396)
faceted-search Coverage: 85%
 85.69% (677/790) 79.37% (304/383) 82.63% (238/288)
flow-designer Coverage: 70%
 70.07% (651/929) 66.72% (355/532) 70.92% (200/282)
forms Coverage: 85%
 85.8% (1638/1909) 75.73% (927/1224) 84.24% (460/546)
http Coverage: 100%
 100% (85/85) 98.07% (51/52) 100% (34/34)
sagas Coverage: 92%
 92.3% (24/26) 66.66% (4/6) 50% (2/4)
stepper Coverage: 80%
 81.52% (150/184) 59.34% (54/91) 80.85% (38/47)
utils Coverage: 100%
 100% (73/73) 90.9% (10/11) 100% (24/24)

@github-actions GitHub Actions
Copy link
Contributor

Size Change: +642 B (0%)

Total Size: 16.9 MB

Filename Size Change
./packages/components/dist/TalendReactComponents.js 4.73 MB +490 B (+0.01%)
./packages/components/dist/TalendReactComponents.min.js 1.26 MB +152 B (+0.01%)
ℹ️ View Unchanged
Filename Size Change
./packages/assets-api/dist/TalendAssetsApi.js 7.09 kB 0 B
./packages/assets-api/dist/TalendAssetsApi.js.dependencies.json 2 B 0 B
./packages/assets-api/dist/TalendAssetsApi.min.js 3.32 kB 0 B
./packages/assets-api/dist/TalendAssetsApi.min.js.dependencies.json 2 B 0 B
./packages/cmf-cqrs/dist/TalendReactCmfCqrs.js 205 kB 0 B
./packages/cmf-cqrs/dist/TalendReactCmfCqrs.js.dependencies.json 670 B 0 B
./packages/cmf-cqrs/dist/TalendReactCmfCqrs.min.js 11.3 kB 0 B
./packages/cmf-cqrs/dist/TalendReactCmfCqrs.min.js.dependencies.json 693 B 0 B
./packages/cmf-router/dist/TalendReactCmfRouter.js 164 kB 0 B
./packages/cmf-router/dist/TalendReactCmfRouter.js.dependencies.json 1.25 kB 0 B
./packages/cmf-router/dist/TalendReactCmfRouter.min.js 12.7 kB 0 B
./packages/cmf-router/dist/TalendReactCmfRouter.min.js.dependencies.json 1.29 kB 0 B
./packages/cmf/dist/TalendReactCmf.js 505 kB 0 B
./packages/cmf/dist/TalendReactCmf.js.dependencies.json 1.3 kB 0 B
./packages/cmf/dist/TalendReactCmf.min.js 65.1 kB 0 B
./packages/cmf/dist/TalendReactCmf.min.js.dependencies.json 1.35 kB 0 B
./packages/components/dist/TalendReactComponents.css 397 kB 0 B
./packages/components/dist/TalendReactComponents.js.dependencies.json 3.21 kB 0 B
./packages/components/dist/TalendReactComponents.min.css 212 kB 0 B
./packages/components/dist/TalendReactComponents.min.js.dependencies.json 3.29 kB 0 B
./packages/containers/dist/TalendReactContainers.css 2.99 kB 0 B
./packages/containers/dist/TalendReactContainers.js 635 kB 0 B
./packages/containers/dist/TalendReactContainers.js.dependencies.json 1.4 kB 0 B
./packages/containers/dist/TalendReactContainers.min.css 1.78 kB 0 B
./packages/containers/dist/TalendReactContainers.min.js 92.8 kB 0 B
./packages/containers/dist/TalendReactContainers.min.js.dependencies.json 1.45 kB 0 B
./packages/dataviz/dist/TalendReactDataviz.css 28.1 kB 0 B
./packages/dataviz/dist/TalendReactDataviz.js 371 kB 0 B
./packages/dataviz/dist/TalendReactDataviz.js.dependencies.json 1.15 kB 0 B
./packages/dataviz/dist/TalendReactDataviz.min.css 12.2 kB 0 B
./packages/dataviz/dist/TalendReactDataviz.min.js 59.5 kB 0 B
./packages/dataviz/dist/TalendReactDataviz.min.js.dependencies.json 1.18 kB 0 B
./packages/design-system/dist/TalendDesignSystem.css 332 kB 0 B
./packages/design-system/dist/TalendDesignSystem.js 1.37 MB 0 B
./packages/design-system/dist/TalendDesignSystem.js.dependencies.json 1.52 kB 0 B
./packages/design-system/dist/TalendDesignSystem.min.css 215 kB 0 B
./packages/design-system/dist/TalendDesignSystem.min.js 245 kB 0 B
./packages/design-system/dist/TalendDesignSystem.min.js.dependencies.json 1.56 kB 0 B
./packages/design-tokens/dist/TalendDesignTokens.css 79.1 kB 0 B
./packages/design-tokens/dist/TalendDesignTokens.js 39.7 kB 0 B
./packages/design-tokens/dist/TalendDesignTokens.js.dependencies.json 2 B 0 B
./packages/design-tokens/dist/TalendDesignTokens.min.css 75 kB 0 B
./packages/design-tokens/dist/TalendDesignTokens.min.js 33.4 kB 0 B
./packages/design-tokens/dist/TalendDesignTokens.min.js.dependencies.json 2 B 0 B
./packages/faceted-search/dist/TalendReactFacetedSearch.css 19.1 kB 0 B
./packages/faceted-search/dist/TalendReactFacetedSearch.js 542 kB 0 B
./packages/faceted-search/dist/TalendReactFacetedSearch.js.dependencies.json 1.54 kB 0 B
./packages/faceted-search/dist/TalendReactFacetedSearch.min.css 6.28 kB 0 B
./packages/faceted-search/dist/TalendReactFacetedSearch.min.js 100 kB 0 B
./packages/faceted-search/dist/TalendReactFacetedSearch.min.js.dependencies.json 1.59 kB 0 B
./packages/flow-designer/dist/TalendReactFlowDesigner.min.js 50.8 kB 0 B
./packages/flow-designer/dist/TalendReactFlowDesigner.min.js.dependencies.json 1.25 kB 0 B
./packages/forms/dist/TalendReactForms.css 20.9 kB 0 B
./packages/forms/dist/TalendReactForms.js 1.46 MB 0 B
./packages/forms/dist/TalendReactForms.js.dependencies.json 1.35 kB 0 B
./packages/forms/dist/TalendReactForms.min.css 6.2 kB 0 B
./packages/forms/dist/TalendReactForms.min.js 267 kB 0 B
./packages/forms/dist/TalendReactForms.min.js.dependencies.json 1.39 kB 0 B
./packages/http/dist/TalendHttp.js 24.6 kB 0 B
./packages/http/dist/TalendHttp.js.dependencies.json 2 B 0 B
./packages/http/dist/TalendHttp.min.js 5.3 kB 0 B
./packages/http/dist/TalendHttp.min.js.dependencies.json 2 B 0 B
./packages/icons/dist/bundle.js 1.26 kB 0 B
./packages/icons/dist/info.js 26.8 kB 0 B
./packages/icons/dist/react.esm.js 614 kB 0 B
./packages/icons/dist/react.js 654 kB 0 B
./packages/icons/dist/talend-icons-webfont.css 18.3 kB 0 B
./packages/icons/dist/talendicons.css 334 B 0 B
./packages/icons/dist/TalendIcons.js 787 kB 0 B
./packages/icons/dist/TalendIcons.js.dependencies.json 128 B 0 B
./packages/icons/dist/TalendIcons.min.js 636 kB 0 B
./packages/icons/dist/TalendIcons.min.js.dependencies.json 131 B 0 B
./packages/icons/dist/typeUtils.js 14.5 kB 0 B
./packages/router-bridge/dist/TalendRouterBridge.js 135 kB 0 B
./packages/router-bridge/dist/TalendRouterBridge.js.dependencies.json 1.05 kB 0 B
./packages/router-bridge/dist/TalendRouterBridge.min.js 21 kB 0 B
./packages/router-bridge/dist/TalendRouterBridge.min.js.dependencies.json 1.07 kB 0 B
./packages/sagas/dist/TalendReactSagas.js 10.8 kB 0 B
./packages/sagas/dist/TalendReactSagas.js.dependencies.json 349 B 0 B
./packages/sagas/dist/TalendReactSagas.min.js 1.41 kB 0 B
./packages/sagas/dist/TalendReactSagas.min.js.dependencies.json 361 B 0 B
./packages/stepper/dist/TalendReactStepper.css 2.41 kB 0 B
./packages/stepper/dist/TalendReactStepper.js 97.9 kB 0 B
./packages/stepper/dist/TalendReactStepper.js.dependencies.json 1.27 kB 0 B
./packages/stepper/dist/TalendReactStepper.min.css 1.2 kB 0 B
./packages/stepper/dist/TalendReactStepper.min.js 9.37 kB 0 B
./packages/stepper/dist/TalendReactStepper.min.js.dependencies.json 1.3 kB 0 B
./packages/storybook-docs/dist/globalStyles.js 0 B 0 B 🆕
./packages/storybook-docs/dist/globalStyles.min.css 384 B 0 B
./packages/storybook-docs/dist/managerStyles.js 0 B 0 B 🆕
./packages/storybook-docs/dist/managerStyles.min.css 1.5 kB 0 B
./packages/theme/dist/bootstrap.css 171 kB 0 B
./packages/theme/dist/bootstrap.js 2.38 kB 0 B
./packages/theme/dist/bootstrap.js.dependencies.json 3 B 0 B

compressed-size-action

aamalric-talend
aamalric-talend approved these changes Aug 12, 2024
View reviewed changes
Copy link
Contributor

@aamalric-talend aamalric-talend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hbhong hbhong merged commit 7121ad1 into master Aug 12, 2024
9 checks passed
@hbhong hbhong deleted the fix/DGHT-180/DateTimeRangeManager branch August 12, 2024 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yyanwang yyanwang yyanwang approved these changes

@aamalric-talend aamalric-talend aamalric-talend approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hbhong @yyanwang @aamalric-talend