Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(tsup.config.js): use banner to add 'use client' directive for nextjs #5816

Closed
wants to merge 8 commits into from

Conversation

manudeli
Copy link
Contributor

@manudeli manudeli commented Jul 31, 2023

related #5815

add tsup banner to add 'use client' directive for nextjs easily

reference

react-wrap-balancer

@vercel
Copy link

vercel bot commented Jul 31, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
query ⬜️ Ignored (Inspect) Visit Preview Sep 5, 2023 0:39am

@nx-cloud
Copy link

nx-cloud bot commented Jul 31, 2023

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 38f9856. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


🟥 Failed Commands
nx affected --targets=test:eslint,test:lib,test:types,test:build,test:bundle

Sent with 💌 from NxCloud.

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jul 31, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 38f9856:

Sandbox Source
@tanstack/query-example-solid-basic-typescript Configuration
@tanstack/query-example-svelte-basic Configuration

@manudeli manudeli marked this pull request as draft July 31, 2023 13:38
@manudeli manudeli marked this pull request as ready for review July 31, 2023 13:52
@TkDodo
Copy link
Collaborator

TkDodo commented Jul 31, 2023

hm, what does this banner do exactly, and why is this better than adding use client manually where we want it?

FYI, we actually want to move away from having use client on all files. Some files should use import client-only instead with a separate server entry point in package.json

I tried this here:

Question is: how does the banner decide to which files a banner should go?

@TkDodo
Copy link
Collaborator

TkDodo commented Aug 1, 2023

@manudeli I created a new PR for the import client-only feature:

I think this would conflict with the banner ?

@TkDodo
Copy link
Collaborator

TkDodo commented Sep 16, 2023

gonna close this because I don't think we want use-client everywhere.

@TkDodo TkDodo closed this Sep 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants