Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(rollup.config.ts): use banner to add 'use client' directive #5815

Closed

Conversation

manudeli
Copy link
Contributor

@manudeli manudeli commented Jul 31, 2023

@vercel
Copy link

vercel bot commented Jul 31, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
query ⬜️ Ignored (Inspect) Jul 31, 2023 0:48am

@nx-cloud
Copy link

nx-cloud bot commented Jul 31, 2023

☁️ Nx Cloud Report

CI is running/has finished running commands for commit a004966. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


🟥 Failed Commands
nx affected --targets=test:eslint,test:lib,test:types,test:build
✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit a004966:

Sandbox Source
@tanstack/query-example-react-basic-typescript Configuration
@tanstack/query-example-solid-basic-typescript Configuration
@tanstack/query-example-svelte-basic Configuration
@tanstack/query-example-vue-basic Configuration

@TkDodo
Copy link
Collaborator

TkDodo commented Jul 31, 2023

thanks for the PR but we've moved away from rollup in v5 so I don't think this PR provides enough value and will cause conflicts on the beta branch.

@TkDodo TkDodo closed this Jul 31, 2023
@manudeli
Copy link
Contributor Author

manudeli commented Jul 31, 2023

thanks for the PR but we've moved away from rollup in v5 so I don't think this PR provides enough value and will cause conflicts on the beta branch.

I fully understood. I'm making Pull Request to use tsup banner for v5-beta too. Wait a moment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants