-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(svelte-query-persist-client): Svelte implementation of client persistence #5928
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 8d573d8. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch
Sent with 💌 from NxCloud. |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 8d573d8:
|
Pushed the formatting fix. The other test that failed was in the react-query package. Edit: looks like the react-query package is fine and now the error is in the solid-query package. |
hey @lachlancollins, do you think you could take a look at this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing work, thanks so much for working on this @aadito123 ! I've had a quick look and everything overall seems good, but I'll have a closer look shortly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much for your contribution @aadito123 !
Any docs @aadito123? Thank you very much for this! |
@frederikhors Nothing right now but I would be happy to work on them. In the meantime, you can look at the test cases for usage examples. |
Thanks. I'll try it asap (I'm still on V4 for now). |
@frederikhors Tag me on any issues. |
I only learned enough Svelte to write this package so please let me know if there's anything wrong. I migrated the React tests to Svelte and all the tests pass.
Also made changes to the base svelte-query package so that
isRestoring
is respected.Only thing missing is the persistence across multiple
QueryClient
s. It is there in the React and Solid implementations because they have reactive wrappers around theQueryClient
whereas the Svelte one does not. Not sure if there is a way to make it reactive in this situation without some API changes.Addresses #5463