Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: useSuspenseQueries broken result type #7189

Closed
wants to merge 2 commits into from

Conversation

elmess-mehdi
Copy link

@elmess-mehdi elmess-mehdi commented Mar 27, 2024

Fix: useSuspenseQueries broken result type

Issue:

Issue 7118

What's in this PR ?

  • In some adapters ,queryFn doesn't include SkipToken as type.
  • This fix included: angular-query-experimental, react-query, solid-query, svelte-query, vue-query.
  • Added a test for useSuspenseQueries in useQueries.test-d.tsx.

Copy link

vercel bot commented Mar 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
query ⬜️ Ignored (Inspect) Visit Preview Apr 5, 2024 5:00pm

Copy link

codesandbox-ci bot commented Mar 27, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 0d5b55b:

Sandbox Source
@tanstack/query-example-angular-basic Configuration
@tanstack/query-example-react-basic-typescript Configuration
@tanstack/query-example-solid-basic-typescript Configuration
@tanstack/query-example-svelte-basic Configuration
@tanstack/query-example-vue-basic Configuration

Copy link

nx-cloud bot commented Mar 27, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 0d5b55b. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

@TkDodo
Copy link
Collaborator

TkDodo commented Apr 5, 2024

huh, we've already fixed #7118 with #7194

can you please verify if that fix was correct or if your additional changes are needed? We also concluded that it wasn't necessary for other adapters because they don't have dedicated useSuspense... hooks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants