New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(solid-query): Ensure correct type inference when using skipToken in createQueries #7221
Conversation
…oken in createQueries
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 33e9413. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 33e9413:
|
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #7221 +/- ##
==========================================
- Coverage 41.42% 41.08% -0.34%
==========================================
Files 184 183 -1
Lines 7331 7355 +24
Branches 1531 1534 +3
==========================================
- Hits 3037 3022 -15
- Misses 3889 3925 +36
- Partials 405 408 +3 |
is this similar to: ? |
While writing test code for
solid-query
, I discovered that type inference fails when askipToken
is present, as shown in the attached photo below. Unlikereact-query
, it does not correctly infer types. I have made modifications tocreateQueries
to ensure accurate type inference.