fix: state issues

examples/react/basic/package.json

@@ -24,5 +24,13 @@
   "devDependencies": {
     "@types/react": "^18.0.25",
     "@types/react-dom": "^18.0.8"
+  },
+  "pnpm": {
+    "overrides": {
+      "@tanstack/router": "workspace:*",
+      "@tanstack/react-actions": "workspace:*",
+      "@tanstack/react-loaders": "workspace:*",
+      "@tanstack/router-devtools": "workspace:*"
+    }
   }
 }

package.json

@@ -8,7 +8,7 @@
     "test:ci": "vitest run",
     "test:dev": "vitest watch",
     "build": "nx run-many --target=build --projects=@tanstack/* --exclude=@tanstack/react-start",
-    "watch": "concurrently --kill-others \"rollup --config rollup.config.js -w\" \"tsc -b --watch\"",
+    "watch": "concurrently --no-color --prefix \"watch\" --kill-others --raw \"rollup --config rollup.config.js -w\" \"tsc -b --watch --preserveWatchOutput\"",
     "dev": "pnpm watch",
     "prettier": "prettier \"packages/*/{src/**,examples/**/src/**}.{md,js,jsx,ts,tsx,json}\" --write",
     "visualize": "pnpm -rc --parallel exec open build/stats-html.html",

packages/store/src/index.ts

@@ -27,9 +27,6 @@ export class Store<
   constructor(initialState: TState, options?: StoreOptions<TState, TUpdater>) {
     this.state = initialState
     this.options = options
-    if (this.options?.onUpdate) {
-      this.subscribe(this.options?.onUpdate)
-    }
   }
 
   subscribe = (listener: Listener) => {
@@ -47,6 +44,10 @@ export class Store<
       ? this.options.updateFn(previous)(updater)
       : (updater as any)(previous)
 
+    // Always run onUpdate, regardless of batching
+    this.options?.onUpdate?.()
+
+    // Attempt to flush
     this._flush()
   }
 

rollup.config.js

@@ -0,0 +1,7 @@
+require('ts-node').register({
+  compilerOptions: {
+    esModuleInterop: true,
+  },
+})
+
+module.exports = require('./rollup.config.ts')

rollup.config.ts

@@ -37,15 +37,9 @@ const babelPlugin = babel({
   extensions: ['.ts', '.tsx'],
 })
 
-export function createRollupConfig(packageName: string): () => RollupOptions[] {
-  const pkg = packages.find((p) => p.name === packageName)
-  if (!pkg) {
-    throw new Error(
-      `Package ${packageName} not found - check the package name given in your package's rollup.config.js file.`,
-    )
-  }
-  return () =>
-    buildConfigs({
+export default function rollup(options: RollupOptions): RollupOptions[] {
+  return packages.flatMap((pkg) => {
+    return buildConfigs({
       name: pkg.packageDir,
       packageDir: `packages/${pkg.packageDir}`,
       jsName: pkg.jsName,
@@ -56,6 +50,7 @@ export function createRollupConfig(packageName: string): () => RollupOptions[] {
       cjs: pkg.cjs ?? true,
       umd: pkg.umd ?? true,
     })
+  })
 }
 
 function buildConfigs(opts: {