Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: rename component created by createLink #1373

Merged
merged 1 commit into from
Mar 26, 2024
Merged

Conversation

TkDodo
Copy link
Contributor

@TkDodo TkDodo commented Mar 26, 2024

because if it's named Link, the world explodes

refs #1271

because if it's named `Link`, the world explodes
Copy link

nx-cloud bot commented Mar 26, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 8769cc8. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

@TkDodo TkDodo merged commit b6595b9 into main Mar 26, 2024
7 checks passed
@TkDodo TkDodo deleted the feature/create-link branch March 26, 2024 13:18
@tannerlinsley
Copy link
Collaborator

😂

@levrik
Copy link

levrik commented Mar 28, 2024

Oh. This explains a lot 😅 I just created my own createLink to work around this because I didn't get why my browser is freezing when using the official API. Implementations seemed identical but I used an arrow function 😬

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants