Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define separate steps in pr.yml #4550

Conversation

fekete965
Copy link
Contributor

I thought it would be easier to see which step failed in the future if they are in a separate step.

@fekete965 fekete965 force-pushed the feat/create-separate-steps-for-pr-gh-action branch from df9e3ab to aced613 Compare November 22, 2022 20:19
@KevinVandy
Copy link
Member

Not familiar with Github Actions as much as Gitlab or BitBucket, but wouldn't we have to set up a bunch of caches and artifacts between the steps to do this? I think we can already easily look at the console output to see while pipelines fail, so we might leave this alone?

Your work that you've contributed is highly appreciated though. I could be wrong and this might be better.

@KevinVandy
Copy link
Member

Actually this pipeline ran your modified pipeline just fine, probably will merge

@KevinVandy KevinVandy merged commit 876b6c1 into TanStack:main Nov 24, 2022
@fekete965
Copy link
Contributor Author

fekete965 commented Nov 24, 2022

Not familiar with Github Actions as much as Gitlab or BitBucket, but wouldn't we have to set up a bunch of caches and artifacts between the steps to do this? I think we can already easily look at the console output to see while pipelines fail, so we might leave this alone?

Your work that you've contributed is highly appreciated though. I could be wrong and this might be better.

Sorry for the late reply! Today's my wife's birthday 🎂 and I was out with her. :D

If you create multiple jobs, then each job will run on a different virtual machine (as far as I know).
If you do that and want to reuse certain data, you need to handle the cache somehow.

If you define steps inside a job, those will be run on the same VM one after another, so cache management is not needed. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants