Add authentication functionality #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey Alex. Thanks for the pull request. Are you one of the developers at Kounta? There are a few warts in the gem that need fixing (e.g. the lack of pagination) and as I'm not working on a paying job using the gem anymore, I don't have a whole lot of incentive to continue work on it. I am happy to transfer ownership however. |
|
I don't work for Kounta - I'm working on an integration with them for a SAAS. Happy to take on ownership of it as I imagine we'll be supporting it for quite a while! I'll contact the Kounta guys and link them to here too, not sure if any of them use Ruby. |
…t check for 200 response status as all 2xx responses are OK
Allow the use of Hashie v3
Cleanup of the gem
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
Thanks for doing the initial work on this.
I've added some functionality to redirect to Kounta URLs and get access tokens so the gem can be used in an authentication flow. README updated too, hopefully it's pretty clear. That said, it's a pretty big change from the current structure so I'm not sure if it ties into how you saw the gem working - interested in thoughts.
Am working on updating the tests at the moment.