Travis build + Conan dependencies managment #73
Conversation
| matrix: | ||
| include: | ||
| - <<: *linux | ||
| env: DOCKER_IMAGE=lasote/conangcc8 |
There was a problem hiding this comment.
Docker image are pulled from the bincrafters SFML configuration
| @@ -56,7 +63,7 @@ if( SFGUI_INCLUDE_FONT ) | |||
| target_compile_definitions( ${TARGET} PRIVATE SFGUI_INCLUDE_FONT ) | |||
| endif() | |||
|
|
|||
| target_link_libraries( ${TARGET} PUBLIC sfml-graphics sfml-window sfml-system ${OPENGL_gl_LIBRARY} ) | |||
| target_link_libraries( ${TARGET} PUBLIC ${CONAN_LIBS} ${SFML_LIBRARIES} ${OPENGL_gl_LIBRARY} ) | |||
There was a problem hiding this comment.
Using the fact that CMake evaluates non-existent variables to nothing.
DrBarbare
force-pushed
the
feature/conan-dependencies-managment
branch
from
9e50f51
to
864ef05
Compare
|
@eXpl0it3r Sorry it took so long to do so simple things... How are the Travis scripts though? My coworkers say that I tend to over complicate things... Also is this account linked to Travis yet? @TankOs? |
DrBarbare
force-pushed
the
feature/conan-dependencies-managment
branch
from
864ef05
to
da5f850
Compare
Added conan as an alternative dependencies getter. Bumped release version. Adding initial travis files, strongly inspired from bincrafters. Add bincrafters repository to conan. Adding docker interaction to travis Trying to add debug output to travis file Make travis docker image work from local directory Running scripts in bash Debuging docker exec steps Adding bash in front of commands. Run travis docker as root Added travis badge. Trying different std abi Trying to get conan to use to correct ABI Trying different stdlibc++ for osx Fixed clang build call Passing environment variables to docker scripts. Fixed install.sh script. Using libc++ with clang Fixed typos in travis Yaml Replaced libc++ from clang, it is not working. Trying to build SFML Trying to refactor travis scripts Fixed typos in scripts Fixed typo docker run -> docker exec Linux seem to be working, trying OSX now. Remove unbound policy for OSX Also remove unbond in run script Apple clang uses libc++ not libstdc++11 Fixed OSX library handling Trying to do without pyenv Typo in target linking cmake Trying windows now. Activating everything YOLO Fixed typo in travis yaml Trying different way to find the conan executable. Still trying to find conan on Windows after choco install Removed faulty printouts Found Conan on windows Fixed no docker invocation on windows Too many conan in path Fixed Windows conan profile Remove libcxx from windows profile Fixed typo in run.sh Git commit trying to run everything in travis. Cleaned the continuous integration scripts. Updated Readme with new build system details Bumped SFML version number Reverted version upgrade change Fixed CMakeLists style Fixed bad manual revert
| @@ -13,17 +13,24 @@ set( SFGUI_VERSION ${SFGUI_MAJOR_VERSION}.${SFGUI_MINOR_VERSION}.${SFGUI_REVISIO | |||
|
|
|||
| ### USER INPUT ### | |||
|
|
|||
| option( SFGUI_BUILD_EXAMPLES "Build examples." ON ) | |||
| option( SFGUI_BUILD_DOC "Generate API documentation." OFF ) | |||
| option( SFGUI_INCLUDE_FONT "Include default font in library (DejaVuSans)." ON ) | |||
There was a problem hiding this comment.
Reordered those so that the indentation still look nice.
|
Totally forgot to check back here, been a while since I've touched SFGUI... 😓 As Travis CI is kind of dead (30 day trial with 10'000 credits) and given that GitHub has since added GitHub Actions, I've gone ahead and added a very basic script with #91 Would you be interested to change this PR (or create a new one) to adapt the conan integration with GitHub Actions instead of Travis CI? |
|
Indeed. this has been quite a while. I didn't even realize Travis was not the hot stuff anymore (I mostly use Jenkins in professional settings). This PR should be closed then. I don't think it would be worth my time to work on Conan integration for this project for a couple reason, first and foremost, my current occupation is very taxing, and I don't feel like spending extra time coding (or doing anything in front of a computer. Thanks to Zoomagedon). Second, I feel like using Conan directly in CMake is better when your project is the final item. For a project like SFGUI, it may be better to write a That being said, if there are other changes you think would benefit the project, and if SFGUI is getting some love back from you lovely maintainers, I will allocate a bit of my free time to port said changes. Thank you for reaching out! |
|
Thanks for getting back to my comment. Might make sense to close the PR, but maybe you could PR the README changes (without the Conan bits), as I think it improves things quite a bit. Do you have time for that or shall I just copy it? |
|
I will see to do it after work today (5-6pm EDT).
…On Fri, Mar 25, 2022 at 4:01 AM Lukas Dürrenberger ***@***.***> wrote:
Thanks for getting back to my comment. Might make sense to close the PR,
but maybe you could PR the README changes (without the Conan bits), as I
think it improves things quite a bit. Do you have time for that or shall I
just copy it?
—
Reply to this email directly, view it on GitHub
<#73 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AJEP46UDYREWNEZWAFOANMDVBVXFDANCNFSM4G3IUQZA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Features
.gitignoreKnown issues
To test
Everything should be in the update documentation. You should still be able to work on the project without the need of Conan, it does make it easier.