Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Zandronum reports stack size exceeded when Roam() is used #10

Closed
ghost opened this issue Apr 16, 2020 · 5 comments · Fixed by #14
Closed

Zandronum reports stack size exceeded when Roam() is used #10

ghost opened this issue Apr 16, 2020 · 5 comments · Fixed by #14

Comments

@ghost
Copy link

ghost commented Apr 16, 2020 •
edited by ghost
Loading

This bug applies to tarcv-master only, don't know if it applies to upgrade.
@TarCV
Copy link
Owner

TarCV commented Apr 17, 2020

I think it's because botc doesn't drop unused return values from the stack. I'll try to fix it on weekend.

@TarCV TarCV mentioned this issue Apr 20, 2020
Merged
@TarCV TarCV closed this as completed in #14 Apr 21, 2020
@TarCV
Copy link
Owner

TarCV commented Apr 21, 2020

@so-sleepy, seeing your like on that PR, I suppose it fixed the issue for you?

@TarCV TarCV mentioned this issue Apr 22, 2020
Open
@ghost
Copy link
Author

ghost commented Apr 22, 2020

You guessed that right, I needed this fix to modify an annoying behavior of the bots, which was a bug, thank you so much. Would you mind if I began testing the upgrade branch and submitting issues?

@TarCV
Copy link
Owner

TarCV commented Apr 23, 2020

Btw, you might be also interested in DH_ARRAYSET bug. From my understanding of bot sources Carnevil's intent doesn't match DH_ARRAYSET implementation.

Help with testing that branch would be really nice, so no issues with that.
Have you encountered any other issues with PR #7?

@ghost
Copy link
Author

ghost commented Apr 23, 2020 •
edited by ghost
Loading

#14 doesn't fix the upgrade branch, I have also commented in #7.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix flooding stack with unused returns for command calls TarCV/botc
1 participant
@TarCV