Fix handling of expression types #7
Conversation
| Expression expr (this, m_lexer, TYPE_ToBeDecided); | ||
| ASSERT_NE(expr.getResult()->valueType(), TYPE_ToBeDecided) | ||
| if (expr.getResult()->valueType() != reqtype) { | ||
| error("Incompatible data type"); |
There was a problem hiding this comment.
error: crashbot.botc:64:near 51: Incompatible data type
if (ChatSectionExistsInChatLump("WinStrings")) {
There was a problem hiding this comment.
Try botc_defs.bts from this branch. 1060356 requires if "argument" to be boolean. (This is what Java does and I think such behavior is more friendly to Doom modders)
When an actual int returning function is used as if argument, you need to rewrite it like if (func() != 0).
There was a problem hiding this comment.
Something I noticed, although I don't know if you would consider it a bug. The compiler complains if the logical operator is used in an int (let's suppose it is named $local1) like $local1 = !($local1). Still converting the source code for the new defs, so far no real issues.
There was a problem hiding this comment.
It compiled and works with the Roam() fix, here is the script I've used http://sprunge.us/v4r7jN.
Fix handling of expression types
Additional fixes for CI: