Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for registering multiple client and server filter #263

Closed
phpcyy opened this issue Dec 28, 2020 · 0 comments
Closed

Support for registering multiple client and server filter #263

phpcyy opened this issue Dec 28, 2020 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers question Further information is requested

Comments

@phpcyy
Copy link
Contributor

phpcyy commented Dec 28, 2020

As far as I know, TarsGo supports registering client filter with tars.RegisterClientFilter() method.
And if you have multiple client filter, you may have to use tars.RegisterPreClientFilter and tars.RegisterPostClientFilter.

However, I don't want to split any of them to one pre filter and one post filter when I register multiple client filters.

For example, I register client breaker filter and client zipkin filter, they may both have pre handle logic and post handle logic.
In the current way, I can only register one client filter. And another client filter has to be split to one pre filter and one client filter.

I think it's a good idea that TarsGo supports muliple filter with using middlewares.

@ETZhangSX ETZhangSX added enhancement New feature or request good first issue Good for newcomers question Further information is requested labels Feb 8, 2021
@phpcyy phpcyy closed this as completed Apr 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants