Misc #12
Merged
Misc #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'd say as a general rule a branch should be either one functional change or one or more single-commit functional changes. I'm just thinking about how I review changes here -- if there are multiple related commits on a branch and other changes as well, then neither "look at individual commits" nor "look at the diff for the entire branch" will work. |
gperciva
force-pushed
the
misc
branch
4 times, most recently
from
4ed2281
to
d25d305
Compare
When trying to do:
tarsnap -c --dry-run ~/backup/
Previously the code complained about
tarsnap: Cannot create an archive with an empty name
By changing the default to "(dry-run)", it runs quite happily.
This includes running mdoc2man.sh
gperciva
force-pushed
the
misc
branch
4 times, most recently
from
6d01563
to
fc4223c
Compare
|
Sorry for the multiple uploads. The |
gperciva
force-pushed
the
misc
branch
2 times, most recently
from
b100807
to
d56f320
Compare
|
ok, this latest version (92d5c36) should be good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BTW, would you prefer a whole bunch of tiny branches (i.e. a different branch, and therefore merge, for each of these commits), or should I continue to dump small misc stuff together?