Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

current_git_tag not updated #180

Closed
RaymondMouthaan opened this issue Jul 13, 2018 · 1 comment
Closed

current_git_tag not updated #180

RaymondMouthaan opened this issue Jul 13, 2018 · 1 comment
Labels

Comments

@RaymondMouthaan
Copy link
Contributor

RaymondMouthaan commented Jul 13, 2018

After running TasmoAdmin v1.5.0 with an earlier (v1.5.0-beta2) created myconfig.php, which has

...
"current_git_tag": "v1.5.0-beta2",
...

TasmoAdmin shows incorrect info on the SelfUpdate page.

screen shot 2018-07-13 at 17 55 23

When changing myconfig.php manually to:

...
"current_git_tag": "v1.5.0",
...

It works like charm:
screen shot 2018-07-13 at 17 58 08

I just wonder why the version is store to myconfig.php, since this will be stored permanently on disk. Now we have introduced environment variables, I think storing the version in myconfig.php should not be done, but read from environment vars instead.
Not sure how this works when running without docker tho....

@reloxx13
Copy link
Collaborator

noticed myself while updating xD

@reloxx13 reloxx13 added the bug label Jul 13, 2018
reloxx13 added a commit that referenced this issue Jul 13, 2018
inverse pushed a commit to inverse/TasmoAdmin that referenced this issue Oct 14, 2020
inverse pushed a commit to inverse/TasmoAdmin that referenced this issue Apr 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants