Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unwanted underscore added #210

Closed
crispy78 opened this issue Sep 4, 2018 · 4 comments
Closed

Unwanted underscore added #210

crispy78 opened this issue Sep 4, 2018 · 4 comments
Labels
Milestone

Comments

@crispy78
Copy link

crispy78 commented Sep 4, 2018

I was fiddling around with TasmoAdmin (docker image) and when I changed my GroupTopic for all devices through the command line option to sonoff (GroupTopic sonoff) there was an underscore added so my GroupTopic became sonoff_
The same happened when I changed Topic to domoticz, it was changed to domoticz_
I’d prefer it wouldn’t add the underscore (unasked).

@reloxx13
Copy link
Collaborator

reloxx13 commented Sep 5, 2018

not reproduceable

if the backlog says "domoticz", than this will be send to tasmota for 100%.
you can even open the console page of tasmota next to tasmoadmin and see the command.

grafik

what i found is, that the command will be send twice since backlog does not give any response, this will be fixed in next release. but still no underscore.

ill close this one and move conservation to the iphone issue.

@reloxx13 reloxx13 closed this as completed Sep 5, 2018
reloxx13 added a commit that referenced this issue Sep 5, 2018
@crispy78
Copy link
Author

crispy78 commented Sep 5, 2018

You should give it a try through the command line option.

https://ibb.co/gq0dPe Is what I’ve sent through the command line, https://ibb.co/fcrDqK is what ended up in my device. Same goes for the Topic command.

@reloxx13 reloxx13 reopened this Sep 5, 2018
@reloxx13
Copy link
Collaborator

reloxx13 commented Sep 5, 2018

ahh i misunderstand that, ill try again

@reloxx13 reloxx13 added this to the 1.6.0 milestone Sep 5, 2018
@reloxx13
Copy link
Collaborator

reloxx13 commented Sep 5, 2018

found it and fixed 👍

uneccessery space was added and tasmota made a _ of it.

removed the failed space, _ gone :)

@reloxx13 reloxx13 closed this as completed Sep 5, 2018
inverse pushed a commit to inverse/TasmoAdmin that referenced this issue Oct 14, 2020
inverse pushed a commit to inverse/TasmoAdmin that referenced this issue Oct 14, 2020
inverse pushed a commit to inverse/TasmoAdmin that referenced this issue Apr 11, 2022
inverse pushed a commit to inverse/TasmoAdmin that referenced this issue Apr 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants