Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add corrections to language files en and fr #1157

Merged
merged 4 commits into from
Apr 27, 2024

Conversation

kilkenny44
Copy link
Contributor

Added Precision to english language file and added correction to french one.

Add precision to PowerOnState info
Correct translation
Copy link
Collaborator

@inverse inverse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes! Unfortunately all changes aside the source language should be done via transifex so that we can manage them easier.

You should be able to sign up and join the team https://github.com/TasmoAdmin/TasmoAdmin?tab=readme-ov-file#translations let me know if you have any luck and I can assign you as a translator to the FR language.

The other change makes sense and I can push this so that others can translate into their language as transifex should show a change was made.

I applied your FR changes to transifex and pulled the language changes in #1158

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you undo changes to this file as we should be doing all translation changes (aside modifying the en source lang) via transifex so that they can be pulled down and updated.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done, I revert this commit

@kilkenny44 kilkenny44 requested a review from inverse April 26, 2024 15:18
Copy link
Collaborator

@inverse inverse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks - I'll push this after the merge and folks working on the translations should get notified of the change.

@inverse inverse merged commit 2c964f0 into TasmoAdmin:master Apr 27, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants