Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Catch guzzle errors in tasotahelper #664

Merged
merged 1 commit into from Sep 18, 2022
Merged

Catch guzzle errors in tasotahelper #664

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
9 changes: 7 additions & 2 deletions tasmoadmin/src/Helper/TasmotaHelper.php
View file
Open in desktop
Expand Up @@ -3,6 +3,7 @@
namespace TasmoAdmin\Helper;

use GuzzleHttp\Client;
use GuzzleHttp\Exception\GuzzleException;
use InvalidArgumentException;
use Parsedown;
use TasmoAdmin\Update\AutoFirmwareResult;
Expand Down Expand Up @@ -106,8 +107,12 @@ private function getLatestRelease(): TasmoFirmwareResult

private function getContents(string $url): string
{
$url = "${url}?r=" . time();
return $this->client->get($url)->getBody()->getContents();
try {
$url = "${url}?r=" . time();
return $this->client->get($url)->getBody()->getContents();
} catch (GuzzleException $exception) {
return sprintf('Failed to load %s - %s', $url, $exception->getMessage());
}
}

private function replaceIssuesWithUrls(string $content): string
Expand Down