New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Linking custom sentences to vocabulary items #1281
Comments
I have a suggestion for (2): Furthermore, I would like to add an auto suggest (dropdown) to the text input if that's ok. |
@dispyfree, I'd suggest to keep these improvements as part of another issue, which you would implement after the scope of this issue has been covered and released. |
I've updated the description with mockups for (2) and (3). |
@dispyfree regarding this issue, I'm not sure what you have started already, but if you haven't done anything yet, you should focus on points (1) and (3). For point (2), since I will be doing a lot of changes in the sentences, better wait until I'm done. |
@trang I'm currently working on (2), I'm almost done. Do you change the database structures entirely, or is it just the code? I'm using AngularJS, so it will be easy to merge if you are currently switching towards that. |
@trang: I'm finished with this issue. Shall I port the code to the directive |
@dispyfree I've posted several comments on your commit. There are some important things to review on the model level. I will check tomorrow for the AngularJS part and will add my comments here in this issue about porting the code. |
@dispyfree I pushed a branch that illustrates briefly how you would begin to port your code into the new sentence UI code: trang@ea9073a In short:
You can pull and test this locally by doing the following:
Obviously you don't have to reuse exactly this code. This is just a very rough example so that you can see more clearly how things are (or can be) connected to each other. If there's something you don't understand in there, don't hesitate to ask. |
@trang: OK, when I'm done with incorporating your comments I'll work on porting the code. I just thought of something else; my branch introduces a flag "automatically_associated" for the link between vocabulary and sentences. |
Parent issue: #1148
Problem
As a user, I can create a list of vocabulary items for words that interest me. From my vocabulary list, I am provided a link that shows the search result for sentences that contain the exact match for the vocabulary.
There are 2 limitations to this:
In most languages, words can have several variations: plural vs. singular, masculine vs. feminine, declension, conjugation, etc. If I add the word "country", I may be interested in sentences that contain "countries", but these sentences won't be linked to my "country" item because the search only takes sentences with an exact match.
Some words have a large amount of sentences (over a thousand), and I usually don't need so many sentences linked to my vocabulary. I only need a handful of them, but there's no way for me to pick a particular sentence.
Suggested solution
(1) In the vocabulary list, we need 2 different links to sentences:
I don't have a great solution for this. The best I can think of is to have the following links:
exact match: {n}
mine: {n}
(2) In the sentences component, we need a button for users to link a sentence to a vocabulary. I don't have a great solution for this either.
library_add
from the Material icons: https://design.google.com/icons/#ic_library_add(3) On the page that lists the custom sentences for a vocabulary item, we can add a button "Sentences suggestions".
+
button next to them. The user can click this button if they want to link that sentence to the current vocabulary item.The text was updated successfully, but these errors were encountered: