Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Linking custom sentences to vocabulary items #1281
Parent issue: #1148
As a user, I can create a list of vocabulary items for words that interest me. From my vocabulary list, I am provided a link that shows the search result for sentences that contain the exact match for the vocabulary.
There are 2 limitations to this:
(1) In the vocabulary list, we need 2 different links to sentences:
I don't have a great solution for this. The best I can think of is to have the following links:
(2) In the sentences component, we need a button for users to link a sentence to a vocabulary. I don't have a great solution for this either.
(3) On the page that lists the custom sentences for a vocabulary item, we can add a button "Sentences suggestions".
I have a suggestion for (2):
Furthermore, I would like to add an auto suggest (dropdown) to the text input if that's ok.
@trang: I'm finished with this issue. Shall I port the code to the directive
You can pull and test this locally by doing the following:
Obviously you don't have to reuse exactly this code. This is just a very rough example so that you can see more clearly how things are (or can be) connected to each other. If there's something you don't understand in there, don't hesitate to ask.
@trang: OK, when I'm done with incorporating your comments I'll work on porting the code.
I just thought of something else; my branch introduces a flag "automatically_associated" for the link between vocabulary and sentences.