Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removal option appears on favorites of other user if the favorited sentence doesn't exist #2821

Open
Yorwba opened this issue Aug 2, 2021 · 0 comments
Labels
bug Issue that describes a problem with a feature that doesn't work as expected.

Comments

@Yorwba
Copy link
Contributor

Yorwba commented Aug 2, 2021

To Reproduce

  1. Go to the profile of another user who has favorited a sentence that has been deleted.
  2. Click the cross next to the sentence, seemingly indicating that it can be removed.
  3. A message indicates that the favorite has been removed successfully.
  4. Reload the page.
  5. Note that the favorite hasn't actually been removed.

Expected behavior
The option to remove the favorite shouldn't appear unless you're looking at your own favorites. Also, when removing a favorite fails for whatever reason, an error message should be displayed.

Screenshots
Pre

Post

Additional information
Reported on the wall: https://tatoeba.org/en/wall/show_message/37404#!#message_37404

@Yorwba Yorwba added the bug Issue that describes a problem with a feature that doesn't work as expected. label Aug 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue that describes a problem with a feature that doesn't work as expected.
Projects
None yet
Development

No branches or pull requests

1 participant