Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Directionality of original lang. for sentence remains after lang. is changed #33

Closed
loolmeh opened this issue Feb 17, 2014 · 3 comments · Fixed by #2077
Closed

Directionality of original lang. for sentence remains after lang. is changed #33

loolmeh opened this issue Feb 17, 2014 · 3 comments · Fixed by #2077
Labels
bug Issue that describes a problem with a feature that doesn't work as expected.
Milestone

Comments

@loolmeh
Copy link
Contributor

loolmeh commented Feb 17, 2014

If a newly created sentence is assigned a language with one directionality, then it will continue to be displayed with the same directionality even after the language is changed. For instance, say that I add an English translation "The sky is blue." to a Hebrew sentence, but I mistakenly mark my translation as Hebrew. I see my mistake immediately because the final period clings to the beginning of the sentence (the left) rather than the end (the right). Now I click on the flag to change it to English. Even though I've changed it, it will still be displayed on my current page with right-to-left directionality (with the period clinging to the beginning rather than the end). If I actually go to the URL of the sentence, it is displayed correctly, however. Thus, this is a transient annoyance rather than a permanent problem. It would still be nice to fix the problem, though.


Original ticket: https://www.assembla.com/spaces/tatoeba2/tickets/407

@jiru jiru added bug Issue that describes a problem with a feature that doesn't work as expected. priority:low labels Sep 25, 2014
@ckjpn
Copy link

ckjpn commented Jan 3, 2016

This is a "feature" of the fact the the full page isn't reloaded, I think.
If you reload the page, then you are likely to see what you expect to see.
My guess it that it saves resources by doing it this way, rather than forcing a complete reload of the page each time a change is made.

@RyckRichards
Copy link
Member

Requested by Guybrush88 on Tatoeba Day 14.

@RyckRichards RyckRichards self-assigned this Mar 20, 2016
@trang trang added enhancement Issue that describes a problem that requires a change in the current functionalities of Tatoeba. and removed bug Issue that describes a problem with a feature that doesn't work as expected. labels May 25, 2016
@trang trang added bug Issue that describes a problem with a feature that doesn't work as expected. and removed enhancement Issue that describes a problem that requires a change in the current functionalities of Tatoeba. labels Jul 29, 2018
@jiru
Copy link
Member

jiru commented Jul 30, 2018

Note that not only the directionality needs to be updated (HTML attribute dir="..."), but also the language (lang="..."), so that appropriate fonts, spell check dictionary etc. are selected by the browser for the sentence text. If the language is changed to a language that has multiple scripts, autodetection should find the script and append it to the lang attribute (for example lang="zh-Hans" for simplified Chinese). Finally, if the language is changed to a language that has transcriptions, the autogenerated transcriptions should show up too.

@trang trang added this to To do in Responsive UI Dec 16, 2019
@trang trang moved this from To do to In progress in Responsive UI Jan 12, 2020
trang added a commit that referenced this issue Jan 18, 2020
This also fixes #33.
@trang trang added this to the 2020-01-26 milestone Jan 18, 2020
@trang trang moved this from In progress to Done in Responsive UI Jan 28, 2020
jiru pushed a commit that referenced this issue Apr 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue that describes a problem with a feature that doesn't work as expected.
Projects
Responsive UI
  
Done
Development

Successfully merging a pull request may close this issue.

5 participants