Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Problem with collapsible translations when linking sentences #628

Closed
trang opened this issue Apr 3, 2015 · 0 comments
Closed

Problem with collapsible translations when linking sentences #628

trang opened this issue Apr 3, 2015 · 0 comments
Labels
bug Issue that describes a problem with a feature that doesn't work as expected.
Milestone
2018-07-01

Comments

@trang
Copy link
Member

trang commented Apr 3, 2015

Reported by Silja:
https://tatoeba.org/eng/wall/show_message/22235#message_22235

Bug detected! I have chosen collapsible translations option. Now when I want to link some existing translations to a sentence, these problems appear:

a) if there are a lot of indirect translations that I want to link, they are hidden everytime I make a link. So I have to click on "show xx translations more" each and every time after when I've made a link.

b) What makes things even more difficult is that the "show xx traslations more" link doesn't work after I've linked the sentence to some translation. I have to first refresh the page and then click on the link.

I think my option to hide or show the translations should be respected even if the page is loaded again when I link two sentences together. The same should go for if I send a comment to a sentence.
@trang trang added the bug Issue that describes a problem with a feature that doesn't work as expected. label Jan 6, 2016
@RyckRichards RyckRichards self-assigned this Mar 20, 2016
@jiru jiru closed this as completed in 58001b1 Jun 25, 2018
@jiru jiru added this to the 2018-07-01 milestone Jun 25, 2018
@jiru jiru mentioned this issue Mar 4, 2019
Closed
trang added a commit that referenced this issue Apr 2, 2020
@trang
Refresh translations upon linking/unlinking
d3d5aff 
Translations are automatically expanded when linking or unlinking (to avoid problem mentioned in #628).

No error message is shown if sentence was already linked or unlinked. We simply refresh the translations no matter what (re #536).
trang added a commit that referenced this issue Apr 6, 2020
@trang
Refresh translations upon linking/unlinking
14d7e26 
Translations are automatically expanded when linking or unlinking (to avoid problem mentioned in #628).

No error message is shown if sentence was already linked or unlinked. We simply refresh the translations no matter what (re #536).
trang added a commit that referenced this issue Apr 11, 2020
@trang
Keep same expanded state of translations when linking/unliniking
9f29300 
This handles more properly the issue in #628. We don't need to expand all the time.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Issue that describes a problem with a feature that doesn't work as expected.
Projects
None yet
Milestone
2018-07-01
Development

No branches or pull requests
3 participants
@trang @jiru @RyckRichards