Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tags without reloading the page #674

Closed
trang opened this issue Jun 6, 2015 · 4 comments
Closed

Add tags without reloading the page #674

trang opened this issue Jun 6, 2015 · 4 comments
Labels
enhancement Issue that describes a problem that requires a change in the current functionalities of Tatoeba.
Milestone

Comments

@trang
Copy link
Member

trang commented Jun 6, 2015

https://tatoeba.org/eng/wall/show_message/22945#message_22945

Category: Helping Members Work More Efficiently

Make it possible to add more than one tag at a time, separated by commas.

Example: OK,SVC,present simple

@trang
Copy link
Member Author

trang commented Jul 25, 2015

This has been requested by CK, Silja and ricardo14.

My problems:

  1. What if a user wants to use a tag with a comma in it? It seems there are several tags with a comma in it.
  2. There are more error cases to handle.
    • We cannot let users add an infinite number of tags at once. What should be the limit, how do we limit it?
    • What if the user tries to add 3 tags, and 2 of them cannot be added, for different reasons. We will need to re-adapt the error message.

It seems the main problem is that users have to wait 2 or 3 seconds between each tag that they add (because adding a tag reloads the page), and the goal is simply to reduce the time between the moment when the user submits a tag, and the moment the user can start adding a new one.

If that's indeed the main issue, then we can solve this differently than by making it possible to add several tags at a time, separated by a comma.

@jiru
Copy link
Member

jiru commented Jul 25, 2015

I second using a different solution that reduces the waiting time in order to avoid the complications you mentioned. Performing an Ajax request instead of reloading the page sounds like a valid solution. It can probably be done so that several tags may be added without having to wait for the response between each submission. Regarding the initial proposition, it eventually boils down to use the return key instead of the comma.

@jiru jiru added the enhancement Issue that describes a problem that requires a change in the current functionalities of Tatoeba. label Jul 31, 2015
@RyckRichards
Copy link
Member

Requested by ricardo14 on Tatoeba Day 4 and on Tatoeba Day 7

@trang trang added this to the 2015-09-14 milestone Sep 12, 2015
trang added a commit that referenced this issue Sep 12, 2015
trang added a commit that referenced this issue Sep 12, 2015
trang added a commit that referenced this issue Sep 12, 2015
trang added a commit that referenced this issue Sep 12, 2015
trang added a commit that referenced this issue Sep 12, 2015
trang added a commit that referenced this issue Sep 12, 2015
Users used to select the value in the dropdown with "enter". Since
"enter" is now used to submit, the value needs to be set when it is
selected in the dropdown list.
@trang trang changed the title Make it possible to add more than one tag at a time, separated by commas Make it possible to add tags without reloading the page Sep 12, 2015
@trang trang changed the title Make it possible to add tags without reloading the page Add tags without reloading the page Sep 12, 2015
@trang trang closed this as completed Sep 12, 2015
@ckjpn
Copy link

ckjpn commented Sep 14, 2015

While I like the new way, I do miss the fact the that top one was selected automatically.

This meant that I was able to just type up to the point where the tag appeared at the top of the list, and then I could hit my return key.

Now, I have to reach over and hit my down arrow key (or reach even further and use my mouse), and then I have the hit the return key.

If you can ever figure out how to add a comma-deleted list of tags all at once, it would be very useful. I often tag a series of sentences with the same tags. for example, I just tagged 4 sentences with "fact, svc, present simple".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Issue that describes a problem that requires a change in the current functionalities of Tatoeba.
Projects
None yet
Development

No branches or pull requests

4 participants