Limit max pages on large sets of results #1945
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice.
I suggest you replace every occurrence of 1000 by a self-explanatory constant. See https://stackoverflow.com/questions/47882/what-is-a-magic-number-and-why-is-it-bad
-- gillux
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses #1353.
Changes were made according to my last comment there:
/sentences/show_all_inis limited to 1000 sentences. Number of page depends on user settings (100 pages if 10 sentences per page)./sentence_comments/indexis limited to 1000 comments. Title changed to "Latest comments"./contributions/indexwas removed./contributions/of_useris limited to the last 1000 log entries. Title changed to "Latest contributions from {username}".