kpathsea: don't depend on GNU libtool internals #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The kpsereadlink.test script checks that the compiled kpsereadlink correctly finds that .libs/libkpathsea.lai is not a symlink and that .libs/libkpathsea.la is a symlink. However this assumption is broken when using slibtool instead of GNU libtool which creates libpathsea.lai as a symlink. A more robust test that works with both GNU libtool and slibtool would be to create a file and symlink to test against rather than to depend on GNU libtool internals. This was reported for Gentoo: https://bugs.gentoo.org/924405
orbea
force-pushed
the
kpathsea-kpsereadlink-slibtool
branch
from
e03d247
to
076911c
Compare
|
thanks much. i applied it (with trivial changes). |
|
Thank you very much for the quick review! |
orbea
added a commit
to orbea/gentoo
that referenced
this pull request
Feb 23, 2024
Closes: https://bugs.gentoo.org/924405 Upstream-PR: TeX-Live/texlive-source#65 Upstream-Commit: TeX-Live/texlive-source@9c4aec9 Signed-off-by: orbea <orbea@riseup.net>
gentoo-bot
pushed a commit
to gentoo/gentoo
that referenced
this pull request
Mar 16, 2024
Closes: https://bugs.gentoo.org/924405 Upstream-PR: TeX-Live/texlive-source#65 Upstream-Commit: TeX-Live/texlive-source@9c4aec9 Signed-off-by: orbea <orbea@riseup.net> Closes: #35494 Signed-off-by: Joonas Niilola <juippis@gentoo.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
kpsereadlink.testscript checks that the compiledkpsereadlinkcorrectly finds that.libs/libkpathsea.laiis not a symlink and that.libs/libkpathsea.lais a symlink.However this assumption is broken when using slibtool instead of GNU libtool which creates
libpathsea.laias a symlink.A more robust test that works with both GNU libtool and slibtool would be to create a file and symlink to test against rather than to depend on GNU libtool internals.
This was reported for Gentoo: https://bugs.gentoo.org/924405