Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

autovectorize spectralnorm #22

Merged
merged 2 commits into from Sep 27, 2015
Merged

Conversation

llogiq
Copy link
Contributor

@llogiq llogiq commented Sep 26, 2015

I just added @TeXitoi's autovectorization suggestion to spectralnorm. This closes #9

Measurements are promising:

$ time bin/spectralnorm_old 5500
1.274224153

real    0m2.496s
user    0m9.159s
sys     0m0.022s

$ time bin/spectralnorm 5500
1.274224153

real    0m2.061s
user    0m7.263s
sys     0m0.027s

Since Rust uses the as-of-yet unstable simd types, there's little point in suggesting they update to this.

@TeXitoi
Copy link
Owner

TeXitoi commented Sep 26, 2015

A PR tourist is not relevant as it can use simd. But if you cannpropose a almost same version using simd, it'll be great.

@llogiq
Copy link
Contributor Author

llogiq commented Sep 26, 2015

Sorry, I didn't get that. Do you mean I should add a #[cfg(simd)] feature that we can switch on and off depending on target?

@TeXitoi
Copy link
Owner

TeXitoi commented Sep 26, 2015

No, I badly read. I was thinking you'll doba PR to rust.

@llogiq
Copy link
Contributor Author

llogiq commented Sep 26, 2015

Ah, I see. 😄 Ok, then.

@llogiq
Copy link
Contributor Author

llogiq commented Sep 26, 2015

r?

@TeXitoi
Copy link
Owner

TeXitoi commented Sep 27, 2015

Thanks, I'll submit it tomorrow.

TeXitoi added a commit that referenced this pull request Sep 27, 2015
@TeXitoi TeXitoi merged commit 5d913bd into TeXitoi:master Sep 27, 2015
@llogiq llogiq deleted the vectorize_spectralnorm branch September 27, 2015 14:10
@llogiq
Copy link
Contributor Author

llogiq commented Oct 5, 2015

This hasn't been submitted as of yet. Can I do something to speed up the process? This also applies to fasta-redux and the other recently updated benchmarks.

@TeXitoi
Copy link
Owner

TeXitoi commented Oct 5, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve spectralnorm
2 participants