New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

autovectorize spectralnorm #22

Merged
merged 2 commits into from Sep 27, 2015

Conversation

Projects
None yet
2 participants
@llogiq
Contributor

llogiq commented Sep 26, 2015

I just added @TeXitoi's autovectorization suggestion to spectralnorm. This closes #9

Measurements are promising:

$ time bin/spectralnorm_old 5500
1.274224153

real    0m2.496s
user    0m9.159s
sys     0m0.022s

$ time bin/spectralnorm 5500
1.274224153

real    0m2.061s
user    0m7.263s
sys     0m0.027s

Since Rust uses the as-of-yet unstable simd types, there's little point in suggesting they update to this.

@TeXitoi

This comment has been minimized.

Show comment
Hide comment
@TeXitoi

TeXitoi Sep 26, 2015

Owner

A PR tourist is not relevant as it can use simd. But if you cannpropose a almost same version using simd, it'll be great.

Owner

TeXitoi commented Sep 26, 2015

A PR tourist is not relevant as it can use simd. But if you cannpropose a almost same version using simd, it'll be great.

@llogiq

This comment has been minimized.

Show comment
Hide comment
@llogiq

llogiq Sep 26, 2015

Contributor

Sorry, I didn't get that. Do you mean I should add a #[cfg(simd)] feature that we can switch on and off depending on target?

Contributor

llogiq commented Sep 26, 2015

Sorry, I didn't get that. Do you mean I should add a #[cfg(simd)] feature that we can switch on and off depending on target?

@TeXitoi

This comment has been minimized.

Show comment
Hide comment
@TeXitoi

TeXitoi Sep 26, 2015

Owner

No, I badly read. I was thinking you'll doba PR to rust.

Owner

TeXitoi commented Sep 26, 2015

No, I badly read. I was thinking you'll doba PR to rust.

@llogiq

This comment has been minimized.

Show comment
Hide comment
@llogiq

llogiq Sep 26, 2015

Contributor

Ah, I see. 😄 Ok, then.

Contributor

llogiq commented Sep 26, 2015

Ah, I see. 😄 Ok, then.

@llogiq

This comment has been minimized.

Show comment
Hide comment
@llogiq

llogiq Sep 26, 2015

Contributor

r?

Contributor

llogiq commented Sep 26, 2015

r?

@TeXitoi

This comment has been minimized.

Show comment
Hide comment
@TeXitoi

TeXitoi Sep 27, 2015

Owner

Thanks, I'll submit it tomorrow.

Owner

TeXitoi commented Sep 27, 2015

Thanks, I'll submit it tomorrow.

TeXitoi added a commit that referenced this pull request Sep 27, 2015

@TeXitoi TeXitoi merged commit 5d913bd into TeXitoi:master Sep 27, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@llogiq llogiq deleted the llogiq:vectorize_spectralnorm branch Sep 27, 2015

@llogiq

This comment has been minimized.

Show comment
Hide comment
@llogiq

llogiq Oct 5, 2015

Contributor

This hasn't been submitted as of yet. Can I do something to speed up the process? This also applies to fasta-redux and the other recently updated benchmarks.

Contributor

llogiq commented Oct 5, 2015

This hasn't been submitted as of yet. Can I do something to speed up the process? This also applies to fasta-redux and the other recently updated benchmarks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment