Default value #312
Merged
Default value #312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CreepySkeleton
force-pushed
the
default_value
branch
from
200654b
to
cd58031
Compare
Merged
|
Ready for review |
TeXitoi
requested changes
Dec 28, 2019
|
Overall great code! |
CreepySkeleton
force-pushed
the
default_value
branch
from
26adae1
to
2d3e10f
Compare
|
Ready |
CreepySkeleton
force-pushed
the
default_value
branch
from
f419c5c
to
d20337d
Compare
|
A warning break the error message tests |
|
Not anymore |
TeXitoi
approved these changes
Dec 29, 2019
|
Number of issues is less than 15! New achievement! 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not meant to be released with the next patch, just some ongoing work.
Closes #123
Closes #142
Closes #150
TODO: docs, changelog