Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V0.3.7 #316

Merged
merged 2 commits into from
Dec 28, 2019
Merged

V0.3.7 #316

merged 2 commits into from
Dec 28, 2019

Conversation

CreepySkeleton
Copy link
Collaborator

Closes #315

An attempt to make the hidden methods compatible with cases like that. cc @bkchr

Copy link

@bkchr bkchr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, ty :)

@CreepySkeleton
Copy link
Collaborator Author

Let's postpone it until we have come up with a consensus with this

@bkchr
Copy link

bkchr commented Dec 25, 2019

In my opinion it is okay to release with these breaking changes, we will just push a fix to our code base.
However, I would vote for not hiding the functions in the StructOpt trait.

@CreepySkeleton
Copy link
Collaborator Author

release with these breaking changes

Again, none of these changes are breaking in semver sense. If you're relying on internal implementation details - you're mostly on your own.

I would vote for not hiding the functions in the StructOpt trait

Those functions are private and I'm planning to tweak them a little in #314 . I think we could move them to some sort of StrutOptMachinery trait, also hidden.

We could stabilize the augment_clap method, probably renaming it to augment_args since this is what the method does. What do you think?

@bkchr
Copy link

bkchr commented Dec 25, 2019

I just wanted to say, that you should not block because of the code I have written. I will just do the changes required and will come up later with a pr to structopt or at least an issue describing what kind of functionality I need :)

@CreepySkeleton
Copy link
Collaborator Author

It's not blocked because of the code someone have written, it's blocked on review from another maintainer, @TeXitoi . If he won't reply in 2 days I'll publish it myself.

@CreepySkeleton
Copy link
Collaborator Author

OK, I'm releasing this on my own since @TeXitoi seems to be unavailable right now, and I'm certain I can take the responsibility for this changes.

augment_clap moved to the StructOptInternal trait, also hidden. I'm not stabilizing it yet since nobody showed interest in this topic and, quite frankly, I don't feel that stabilizing anything without an approval from @TeXitoi would be fair.

@CreepySkeleton CreepySkeleton merged commit efbdda4 into master Dec 28, 2019
@CreepySkeleton CreepySkeleton deleted the v0.3.7 branch December 28, 2019 17:24
@TeXitoi
Copy link
Owner

TeXitoi commented Dec 28, 2019

Sorry, didn't find the time to review.

@CreepySkeleton
Copy link
Collaborator Author

CreepySkeleton commented Dec 28, 2019

@TeXitoi you can make it up to me by reviewing #312 😏

@TeXitoi
Copy link
Owner

TeXitoi commented Dec 28, 2019

It would be approved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

structopt-derive 0.3.6 breaks structopt <=0.3.5
3 participants