-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
V0.3.7 #316
V0.3.7 #316
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, ty :)
2770c1f
to
4926f5e
Compare
Let's postpone it until we have come up with a consensus with this |
In my opinion it is okay to release with these breaking changes, we will just push a fix to our code base. |
Again, none of these changes are breaking in semver sense. If you're relying on internal implementation details - you're mostly on your own.
Those functions are private and I'm planning to tweak them a little in #314 . I think we could move them to some sort of We could stabilize the |
I just wanted to say, that you should not block because of the code I have written. I will just do the changes required and will come up later with a pr to structopt or at least an issue describing what kind of functionality I need :) |
It's not blocked because of the code someone have written, it's blocked on review from another maintainer, @TeXitoi . If he won't reply in 2 days I'll publish it myself. |
4926f5e
to
c2e0e8c
Compare
OK, I'm releasing this on my own since @TeXitoi seems to be unavailable right now, and I'm certain I can take the responsibility for this changes.
|
Sorry, didn't find the time to review. |
It would be approved. |
Closes #315
An attempt to make the hidden methods compatible with cases like that. cc @bkchr