Issue 324 #325
Merged
Issue 324 #325
+70
−60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CreepySkeleton
force-pushed
the
issue_324
branch
from
80486ff
to
dc3f04f
Compare
TeXitoi
approved these changes
Jan 13, 2020
epage
added a commit
to epage/clap
that referenced
this pull request
Oct 5, 2021
TeXitoi/structopt#325 special cased `version` because a default method would be added if the user did nothing, which caused problems when nesting subcommands. We no longer apply that default method and the highest item in the chain always has precedence, so this can be simplified / clarified.
epage
added a commit
to epage/clap
that referenced
this pull request
Oct 6, 2021
TeXitoi/structopt#325 special cased `version` because a default method would be added if the user did nothing, which caused problems when nesting subcommands. We no longer apply that default method and the highest item in the chain always has precedence, so this can be simplified / clarified.
epage
added a commit
to epage/clap
that referenced
this pull request
Oct 7, 2021
TeXitoi/structopt#325 special cased `version` because a default method would be added if the user did nothing, which caused problems when nesting subcommands. We no longer apply that default method and the highest item in the chain always has precedence, so this can be simplified / clarified.
2 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #324
This makes
versioneven more special. normally, I would just relocatedlop_level_args()after theaugment_clapcall, but this would break other use cases, likeclap::ArgGroup, which must be set before the.args()are set. So, only the.version()call is relocated.This PR also relaxes restriction on
#[structopt(name)]- now it can take any expr, not only strung literal. The code is much cleaner this way.