refactor(derive): Always do app_methods last #2819
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will unblock us from removing the `version` hack because we'll always get the right precedence. Later we can explore ways of moving the app methods to being done first. The big problem is with `#[clap(subcommand)]` because we need to call those app methods on the subcommands `App` *and* override them with app methods on the variant, requiring the app methods to be last to get precedence.
TeXitoi/structopt#325 special cased `version` because a default method would be added if the user did nothing, which caused problems when nesting subcommands. We no longer apply that default method and the highest item in the chain always has precedence, so this can be simplified / clarified.
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By doing this, we can revert TeXitoi/structopt#325 since we no longer need to special case
version.I was hoping to move app methods first, but this is some clean in the complete opposite direction up as I think further about the problem. The issue is with subcommands which need to call into the
Argsfor each variant and it needs the subcommand App to be initialized by theArgs, followed by the variant's app methods overriding that.