Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add insets to ioconfig #295

Merged
merged 1 commit into from
Jul 13, 2023

Conversation

mystchonky
Copy link
Contributor

Description

Allows adding insets to ioconfig renderer. This lets it fit in shape/size of screen. Merge before #172.

Create an inset like following and pass it to IOConfigButton constructor:

var inset = new IOConfigButton.Inset(20, 20, 20, 20);

Checklist:

  • My code follows the style guidelines of this project (.editorconfig, most IDEs will use this for you).
  • I have performed a self-review of my own code.
  • I have commented my code in areas it may be challenging to understand.
  • I have made corresponding changes to the documentation.
  • My changes are ready for review from a contributor.

Copy link
Member

@Rover656 Rover656 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unable to test rn, but code wise looks good; just a code style thing for ya. Cheers!

@Rover656 Rover656 added Type-Enhancement New feature or enhancement to existing feature. Area-Backend Backend work not usually visible to players. MC-1.20.1 labels Jul 12, 2023
Copy link
Member

@Rover656 Rover656 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lookin good! cheers!!

@Rover656 Rover656 merged commit a46e587 into Team-EnderIO:dev/1.20.1 Jul 13, 2023
1 check passed
@mystchonky mystchonky mentioned this pull request Jul 13, 2023
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Backend Backend work not usually visible to players. MC-1.20.1 Type-Enhancement New feature or enhancement to existing feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants