Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace slicer recipe cache with a slot aware recipe cache #461

Merged
merged 2 commits into from Aug 18, 2023

Conversation

agnor99
Copy link
Contributor

@agnor99 agnor99 commented Aug 14, 2023

Description

Swap out the recipe cache for the slicer to one that cares about slot indices
Closes #384

Checklist:

  • My code follows the style guidelines of this project (.editorconfig, most IDEs will use this for you).
  • I have performed a self-review of my own code.
  • I have commented my code in areas it may be challenging to understand.
  • I have made corresponding changes to the documentation.
  • My changes are ready for review from a contributor.

Copy link
Member

@Rover656 Rover656 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I might've suggested making this more generic, but this fix looks like it works perfectly fine at the minute, so no need to complicate things. Thanks a lot agnor :)

@Rover656 Rover656 merged commit d27230b into dev/1.20.1 Aug 18, 2023
3 checks passed
@Rover656 Rover656 deleted the fix/slicenspliceslots branch August 18, 2023 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make the slice and splice slot specific
4 participants