Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] 회원 행복 루틴 조회 #83

Merged
merged 6 commits into from
Jan 12, 2024
Merged

Conversation

thguss
Copy link
Member

@thguss thguss commented Jan 12, 2024

✨ Related Issue

📝 기능 구현 명세

image

🐥 추가적인 언급 사항

  • 행복 루틴 추가 PR 병합 후 리뷰 받고 병합 진행하도록 하겠습니다. (충돌 예방 목적)

@thguss thguss added sohyeon 소현 작업 feat 기능 개발 test 테스트 labels Jan 12, 2024
@thguss thguss self-assigned this Jan 12, 2024
@thguss thguss added the hold review 리뷰 보류 (이전 PR 영향을 받을 때) label Jan 12, 2024
@thguss thguss removed the hold review 리뷰 보류 (이전 PR 영향을 받을 때) label Jan 12, 2024
Copy link
Contributor

@Chan531 Chan531 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다~!

String timeTaken
) {

public static MemberHappinessRoutinesResponse of(MemberHappinessRoutine routine) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

get의 향연이다...


public interface MemberHappinessRoutineService {

MemberHappinessRoutineResponse createMemberHappinessRoutine(Long memberId, MemberHappinessRoutineRequest request);
MemberHappinessRoutinesResponse getMemberHappinessRoutine(Long memberId);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

들여쓰기(?)는 의도된 것인가요?

when(controller.getMemberHappinessRoutine(principal)).thenReturn(response);

// then
mockMvc
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

뭔가 메이플 그 점프 뛰어서 넘는 그런 맵 같네요..

Copy link
Contributor

@csb9427 csb9427 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다~~

@thguss thguss merged commit 260dee4 into develop Jan 12, 2024
1 check passed
@thguss thguss deleted the feature/#80-routine-get-api branch January 12, 2024 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat 기능 개발 sohyeon 소현 작업 test 테스트
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEAT] 유저 별 행복루틴 조회
3 participants