Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TEST] 내가 만든 기능들 테스트 코드 작성하기 #99

Merged
merged 6 commits into from
Jan 14, 2024

Conversation

csb9427
Copy link
Contributor

@csb9427 csb9427 commented Jan 13, 2024

✨ Related Issue

#79

📝 기능 구현 명세

  • 이곳에는 postman 테스트 결과를 넣어주세요

🐥 추가적인 언급 사항

일단 testcode 두 개 짠거만 먼저 머지하려고요 그럼이제 제게 남은 건 행복루틴 예외처리 테스트 코드 3개군요.. 후후 여러분들 감사합니다.

@csb9427 csb9427 added the hold review 리뷰 보류 (이전 PR 영향을 받을 때) label Jan 13, 2024
@csb9427 csb9427 added seungbin 승빈 작업 test 테스트 and removed hold review 리뷰 보류 (이전 PR 영향을 받을 때) labels Jan 13, 2024
Copy link
Contributor

@Chan531 Chan531 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다~!

Copy link
Member

@thguss thguss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다~

import lombok.Getter;
import lombok.NoArgsConstructor;

@Entity
@NoArgsConstructor
@AllArgsConstructor
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixture 쪽에서 Response 내에 직접 값을 넣는 걸로 변경하여 엔티티 생성자가 필요 없는 것으로 기억하고 있어요. 생성자 삭제 부탁드려요!

Comment on lines 9 to 10
@NoArgsConstructor
@AllArgsConstructor
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

여기 생성자도 삭제 부탁드려요!

@csb9427 csb9427 merged commit 03b2da2 into develop Jan 14, 2024
1 check passed
@csb9427 csb9427 deleted the feature/#79-test-code-api branch January 14, 2024 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
seungbin 승빈 작업 test 테스트
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants