Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add vision rotation #6

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Add vision rotation #6

wants to merge 6 commits into from

Conversation

c-bassx
Copy link
Member

@c-bassx c-bassx commented Mar 12, 2024

The 3d coordinates provided by the luxonis oak-d need to be rotated 90 degrees counterclockwise about the x-axis before being inputted into a SwerveAuto command or else it won't work properly

@MaxAPCS
Copy link
Member

MaxAPCS commented Mar 12, 2024

was holding off on adding transformation until the entire transform was known

also, prefer wpilib's Units over java's Math

@c-bassx
Copy link
Member Author

c-bassx commented Mar 12, 2024

I changed the unit conversion to use the Units class instead of Math, can you re-review the pr? Fixing the null check is important for when we use IntakeAuto with the luxonis system

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants