General Fixes and Improvements to lighting #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
T1mothyyang
force-pushed
the
ligthing-fixes
branch
2 times, most recently
from
c5b164d
to
a99220f
Compare
More lighting effects Abstracted more parts of TwoWayComm
T1mothyyang
force-pushed
the
ligthing-fixes
branch
from
a99220f
to
1888a3c
Compare
Codecov Report
@@ Coverage Diff @@
## master #55 +/- ##
==========================================
- Coverage 62.79% 62.72% -0.07%
==========================================
Files 51 51
Lines 758 762 +4
Branches 59 62 +3
==========================================
+ Hits 476 478 +2
- Misses 282 284 +2
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More lighting effects
Abstracted more parts of TwoWayComm