Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add package name to App Manager #3781

Merged
merged 3 commits into from
Jun 5, 2023
Merged

Conversation

VishnuSanal
Copy link
Member

Description

Issue tracker

Fixes #3780

Automatic tests

  • Added test cases

Manual tests

  • Done

Build tasks success

Successfully running following tasks on local:

  • ./gradlew assembledebug
  • ./gradlew spotlessCheck

@TranceLove
Copy link
Collaborator

@VishnuSanal Sometimes when I come back from other app when I'm in app manager the package names will disappear.

Steps to reproduce:

  1. Open App Manager
  2. The apps and package names are there
  3. Open an app from App Manager
  4. Mangle around
  5. Exit app opened in 3, go back to App Manager
  6. App list is there but without package names

Fairphone 3 running LineageOS 19.1 (Android 12).

@VishnuSanal
Copy link
Member Author

@TranceLove can't reproduce :( When I come back from another app, the package names are visible & the list just jumps to the top. I tested on an Android 12 emulator, Android 13 emulator & my daily driver (A11). Maybe, the TextView got hidden since its visibility is set to GONE by default (and it didn't get set to VISIBLE from AppHolder#init when AppManager was opened again)? 🤔

@TranceLove
Copy link
Collaborator

TranceLove commented Apr 30, 2023

@TranceLove can't reproduce :( When I come back from another app, the package names are visible & the list just jumps to the top. I tested on an Android 12 emulator, Android 13 emulator & my daily driver (A11). Maybe, the TextView got hidden since its visibility is set to GONE by default (and it didn't get set to VISIBLE from AppHolder#init when AppManager was opened again)? 🤔

I tried clean build once more from my Fairphone 3 again, seems I couldn't reproduce it either. Also tried again with Pixel 6 emulator running Android 13, same result.

I'd consider my previous comment as false alarm.

TranceLove
TranceLove previously approved these changes Apr 30, 2023
Copy link
Member

@VishalNehra VishalNehra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Required changes in UI as per discussion

VishnuSanal and others added 2 commits May 29, 2023 12:33
Signed-off-by: VishnuSanal <t.v.s10123@gmail.com>
@VishalNehra VishalNehra merged commit 470c77f into release/4.0 Jun 5, 2023
4 checks passed
@VishalNehra VishalNehra deleted the app-manager-package-name branch June 5, 2023 04:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show package name in app manager
3 participants