SSH related fixes #3829
Merged
SSH related fixes #3829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- fix create dir failure when copying folder structure - when using SftpClientTemplate, closeClientOnFinish flag should set to true; it only closes the SFTPClient but not the underlying SSHClient session. This should help avoid the problems with SFTPClient sessions, breaking the whole SSH session altogether
VishalNehra
approved these changes
Jun 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes SSH I/O related problems, as well as adding input filter to default path at SftpConnectDialog to prevent illegal characters.
Issue tracker
Fixes #3543
Fixes #3805
Manual tests
Done
Device: Pixel 6 emulator
OS: Android 13
Build tasks success
Successfully running following tasks on local:
./gradlew assembledebug./gradlew spotlessCheck