Fix NetworkOnMainThreadException on HybridFile.getUsableSpace() and HybridFileParcelable.isDirectory() #3999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To prevent unnecessary calls to superclass method when information is already available at HybridFileParcelable. This also fixes a problem that stops copying folders over SSH.
TranceLove
added
Issue-Bug
VishalNehra
requested changes
Nov 30, 2023
app/src/main/java/com/amaze/filemanager/filesystem/HybridFileParcelable.java
Outdated
Show resolved
Hide resolved
Restrict only SMB and SSH HybridFileParcelables returns the isDirectory attribute; others will use the superclass (HybridFile) implementation. Meanwhile, also fixes a potential flaw at HybridFile.isDirectory() for SMB files which is not wrapped in RxJava's Single in IO scheduler.
Toast the user if there is problem listing files. Hence LoadFilesListTask will have Throwable as progress update, for different list methods to feed exceptions to the UI.
|
Added an alert dialog which will pop up when attempt to load SMB server root without credentials failed. Per Samba docs it indicates it's a good practice to restrict unauthenticated access to SMB server root, or in other words, the 
|
VishalNehra
approved these changes
Dec 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
SmbFile.getDiskSpace()was not wrapped with RxJava inHybridFile.getUsableSpace()for network callsHybridFileParcelable.isDirectory(Context)that made copy and paste remote folders unnecessary long, especially when remote is SSH serverIssue tracker
Fixes #3982
Manual tests
Device:
Build tasks success
Successfully running following tasks on local:
./gradlew assembledebug./gradlew spotlessCheck